crypto: api - Fix liveliness check in crypto_alg_tested

[ Upstream commit b81e286ba154a4e0f01a94d99179a97f4ba3e396 ]

As algorithm testing is carried out without holding the main crypto
lock, it is always possible for the algorithm to go away during the
test.

So before crypto_alg_tested updates the status of the tested alg,
it checks whether it's still on the list of all algorithms.  This
is inaccurate because it may be off the main list but still on the
list of algorithms to be removed.

Updating the algorithm status is safe per se as the larval still
holds a reference to it.  However, killing spawns of other algorithms
that are of lower priority is clearly a deficiency as it adds
unnecessary churn.

Fix the test by checking whether the algorithm is dead.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/crypto/algapi.c b/crypto/algapi.c
index 5dc9ccdd5a510a5645398121ab5a475cfb2d0c92..206a13f3959676370a602f78527bb26c0a5d9b01 100644 (file)
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -341,7 +341,7 @@ found:
        q->cra_flags |= CRYPTO_ALG_DEAD;
        alg = test->adult;
 
-       if (list_empty(&alg->cra_list))
+       if (crypto_is_dead(alg))
                goto complete;
 
        if (err == -ECANCELED)