]> git.hungrycats.org Git - linux/commitdiff
PCI: imx6: Fix establish link failure in EP mode for i.MX8MM and i.MX8MP
authorRichard Zhu <hongxing.zhu@nxp.com>
Mon, 29 Jul 2024 20:18:08 +0000 (16:18 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:33:24 +0000 (16:33 +0200)
commit 5214ff221a14cadab1e2ee29499750fd5e884feb upstream.

Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata.

This flag was overlooked during code restructuring. It is crucial to
release the app-reset from the System Reset Controller before initiating
LTSSM to rectify the issue.

Fixes: 0c9651c21f2a ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET")
Link: https://lore.kernel.org/linux-pci/20240729-pci2_upstream-v8-1-b68ee5ef2b4d@nxp.com
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
[kwilczynski: commit log]
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <stable@vger.kernel.org> # 6.9+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/controller/dwc/pci-imx6.c

index aed3251b40872efd5a35d616f03377dc4883e050..7074184278e942cfdc3d9f1d91f7c73a806bd6fa 100644 (file)
@@ -1579,7 +1579,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
        },
        [IMX8MM_EP] = {
                .variant = IMX8MM_EP,
-               .flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
+               .flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
+                        IMX6_PCIE_FLAG_HAS_PHYDRV,
                .mode = DW_PCIE_EP_TYPE,
                .gpr = "fsl,imx8mm-iomuxc-gpr",
                .clk_names = imx8mm_clks,
@@ -1590,7 +1591,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
        },
        [IMX8MP_EP] = {
                .variant = IMX8MP_EP,
-               .flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
+               .flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
+                        IMX6_PCIE_FLAG_HAS_PHYDRV,
                .mode = DW_PCIE_EP_TYPE,
                .gpr = "fsl,imx8mp-iomuxc-gpr",
                .clk_names = imx8mm_clks,