]> git.hungrycats.org Git - linux/commitdiff
pinctrl: mt7622: fix error path on failing at groups building
authorSean Wang <sean.wang@mediatek.com>
Fri, 22 Jun 2018 03:49:04 +0000 (11:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Jul 2018 13:15:58 +0000 (15:15 +0200)
commit fafa35cce34ba4c4f6fd7f1026c038de0a2884af upstream.

It should be to return an error code when failing at groups building.

Cc: stable@vger.kernel.org
Fixes: d6ed93551320 ("pinctrl: mediatek: add pinctrl driver for MT7622 SoC")
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pinctrl/mediatek/pinctrl-mt7622.c

index 06e8406c444032f5ca3b9bb8ec809f2ec02ddb62..44c1bbfa8a1f1e5786487bc6070717a21d1eab83 100644 (file)
@@ -1561,7 +1561,7 @@ static int mtk_pinctrl_probe(struct platform_device *pdev)
        err = mtk_build_groups(hw);
        if (err) {
                dev_err(&pdev->dev, "Failed to build groups\n");
-               return 0;
+               return err;
        }
 
        /* Setup functions descriptions per SoC types */