]> git.hungrycats.org Git - linux/commitdiff
sky2: NAPI bug
authorStephen Hemminger <shemminger@osdl.org>
Mon, 17 Jul 2006 17:51:50 +0000 (13:51 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Aug 2006 03:52:14 +0000 (20:52 -0700)
If the sky2 driver decides to defer processing because it's NAPI
packet quota is done, then it won't correctly handle the rest
when it is rescheduled.

Signed-off-by: Stephen Hemminger <sch@sch-laptop.localdomain>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/sky2.c

index fba1e4d4d83d053becf3da50e48577f7740f0c79..a3cd0b37385cd8c95c3ee0b07c4dc97c4ed73c2b 100644 (file)
@@ -2187,9 +2187,6 @@ static int sky2_poll(struct net_device *dev0, int *budget)
        int work_done = 0;
        u32 status = sky2_read32(hw, B0_Y2_SP_EISR);
 
-       if (!~status)
-               goto out;
-
        if (status & Y2_IS_HW_ERR)
                sky2_hw_intr(hw);
 
@@ -2226,7 +2223,7 @@ static int sky2_poll(struct net_device *dev0, int *budget)
 
        if (sky2_more_work(hw))
                return 1;
-out:
+
        netif_rx_complete(dev0);
 
        sky2_read32(hw, B0_Y2_SP_LISR);