]> git.hungrycats.org Git - linux/commitdiff
[PATCH] ide-tape: warn about soon to be removed OnStream support
authorBartlomiej Zolnierkiewicz <b.zolnierkiewicz@elka.pw.edu.pl>
Mon, 16 Feb 2004 05:46:43 +0000 (21:46 -0800)
committerLinus Torvalds <torvalds@evo.osdl.org>
Mon, 16 Feb 2004 05:46:43 +0000 (21:46 -0800)
I see only pros of removing OnStream support:
 - SCSI osst.c driver is actively maintained by Willem Riede <wrlk@riede.org>
 - there is no functionality loss (OnStream IDE drives don't support DSC)
 - ide-tape.c driver is too ugly & complicated even without OnStream support
 - long term benefits (2.7.x plans on unifying storage drivers)

drivers/ide/ide-tape.c

index bd4b9dfc70a6b58df9204fbe3160ae06243ba077..ad976e3f052a484259590488d1effa4df987328e 100644 (file)
@@ -6442,12 +6442,12 @@ static int idetape_attach (ide_drive_t *drive)
                goto failed;
        }
        if (drive->scsi) {
-               if (strstr(drive->id->model, "OnStream DI-")) {
-                       printk("ide-tape: ide-scsi emulation is not supported for %s.\n", drive->id->model);
-               } else {
-                       printk("ide-tape: passing drive %s to ide-scsi emulation.\n", drive->name);
-                       goto failed;
-               }
+               printk("ide-tape: passing drive %s to ide-scsi emulation.\n", drive->name);
+               goto failed;
+       }
+       if (strstr(drive->id->model, "OnStream DI-")) {
+               printk(KERN_WARNING "ide-tape: Use drive %s with ide-scsi emulation and osst.\n", drive->name);
+               printk(KERN_WARNING "ide-tape: OnStream support will be removed soon from ide-tape!\n");
        }
        tape = (idetape_tape_t *) kmalloc (sizeof (idetape_tape_t), GFP_KERNEL);
        if (tape == NULL) {