]> git.hungrycats.org Git - linux/commitdiff
wifi: mt76: mt7915: check devm_kasprintf() returned value
authorMa Ke <make24@iscas.ac.cn>
Tue, 3 Sep 2024 01:49:55 +0000 (09:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:33:37 +0000 (16:33 +0200)
commit 267efeda8c55f30e0e7c5b7fd03dea4efec6916c upstream.

devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://patch.msgid.link/20240903014955.4145423-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/mediatek/mt76/mt7915/init.c

index a978f434dc5e64b89822e28310b58dfdd70f74b0..7bc3b4cd359255b9eb0217a2ae2240e7a197584c 100644 (file)
@@ -194,6 +194,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
 
        name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7915_%s",
                              wiphy_name(wiphy));
+       if (!name)
+               return -ENOMEM;
 
        cdev = thermal_cooling_device_register(name, phy, &mt7915_thermal_ops);
        if (!IS_ERR(cdev)) {