]> git.hungrycats.org Git - linux/commitdiff
staging: vt6655: device_rx_srv check sk_buff is NULL
authorMalcolm Priestley <tvboxspy@gmail.com>
Sun, 31 May 2015 09:35:28 +0000 (10:35 +0100)
committerWilly Tarreau <w@1wt.eu>
Fri, 18 Sep 2015 11:52:09 +0000 (13:52 +0200)
commit b5eeed8cb6097c8ea660b6598d36fdbb94065a22 upstream.

There is a small chance that pRD->pRDInfo->skb could go NULL
while the interrupt is processing.

Put NULL check on loop to break out.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust context, indentation]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit 35ee488df7402c0549f8329dc20690cf7fe22492)

Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/staging/vt6655/device_main.c

index 269d1e2382b75d050e5bb17c89d09af97ac9a7fd..1680bed059b10eb6f5d6f45ddbfb913186025703 100644 (file)
@@ -1605,6 +1605,10 @@ static int device_rx_srv(PSDevice pDevice, UINT uIdx) {
 //        DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "pDevice->pCurrRD = %x, works = %d\n", pRD, works);
         if (works++>15)
             break;
+
+        if (!pRD->pRDInfo->skb)
+            break;
+
         if (device_receive_frame(pDevice, pRD)) {
             if (!device_alloc_rx_buf(pDevice,pRD)) {
                     DBG_PRT(MSG_LEVEL_ERR, KERN_ERR