]> git.hungrycats.org Git - linux/commitdiff
cpuset: make sure new tasks conform to the current config of the cpuset
authorZefan Li <lizefan@huawei.com>
Tue, 9 Aug 2016 03:25:01 +0000 (11:25 +0800)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 12 Sep 2016 13:30:26 +0000 (09:30 -0400)
[ Upstream commit 06f4e94898918bcad00cdd4d349313a439d6911e ]

A new task inherits cpus_allowed and mems_allowed masks from its parent,
but if someone changes cpuset's config by writing to cpuset.cpus/cpuset.mems
before this new task is inserted into the cgroup's task list, the new task
won't be updated accordingly.

Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
kernel/cpuset.c

index f0acff0f66c91380412dcbc1c899c94b1d3236b0..388fc6f78c6f09fbef2309962f64f704203dceba 100644 (file)
@@ -2042,6 +2042,20 @@ static void cpuset_bind(struct cgroup_subsys_state *root_css)
        mutex_unlock(&cpuset_mutex);
 }
 
+/*
+ * Make sure the new task conform to the current state of its parent,
+ * which could have been changed by cpuset just after it inherits the
+ * state from the parent and before it sits on the cgroup's task list.
+ */
+void cpuset_fork(struct task_struct *task)
+{
+       if (task_css_is_root(task, cpuset_cgrp_id))
+               return;
+
+       set_cpus_allowed_ptr(task, &current->cpus_allowed);
+       task->mems_allowed = current->mems_allowed;
+}
+
 struct cgroup_subsys cpuset_cgrp_subsys = {
        .css_alloc      = cpuset_css_alloc,
        .css_online     = cpuset_css_online,
@@ -2051,6 +2065,7 @@ struct cgroup_subsys cpuset_cgrp_subsys = {
        .cancel_attach  = cpuset_cancel_attach,
        .attach         = cpuset_attach,
        .bind           = cpuset_bind,
+       .fork           = cpuset_fork,
        .legacy_cftypes = files,
        .early_init     = 1,
 };