]> git.hungrycats.org Git - linux/commitdiff
can: kvaser_usb: fix return value for hif_usb_send_regout
authorChen Ni <nichen@iscas.ac.cn>
Tue, 21 May 2024 04:10:20 +0000 (12:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2024 07:53:33 +0000 (09:53 +0200)
[ Upstream commit 0d34d8163fd87978a6abd792e2d8ad849f4c3d57 ]

As the potential failure of usb_submit_urb(), it should be better to
return the err variable to catch the error.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://lore.kernel.org/all/20240521041020.1519416-1-nichen@iscas.ac.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c

index ffc3e932925018aae4b6c1418b88e5a9867ed5e3..024169461cad0c9d5b7674adb49f55675988c1d5 100644 (file)
@@ -295,7 +295,7 @@ int kvaser_usb_send_cmd_async(struct kvaser_usb_net_priv *priv, void *cmd,
        }
        usb_free_urb(urb);
 
-       return 0;
+       return err;
 }
 
 int kvaser_usb_can_rx_over_error(struct net_device *netdev)