staging: dgnc: Fix frame size is larger than 1024B

commit ea6e9dea2e72a7abd146a2c5bab726b27f34b36c upstream.

This comit fixes the following sparse warnign:

drivers/staging/dgnc/dgnc_tty.c:572:1:
    warning: the frame size of 1060 bytes is larger than 1024 bytes
    [-Wframe-larger-than=]

This was caused by having buffer as an automatic variable. This commit
moves it from the stack to the heap.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 4135cb0ed9f5b4e852b7c166cd138b95388d1b0d..cd7a6dbdddb846c43ff37ff1bf96d413c3e14ed0 100644 (file)
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -481,13 +481,18 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int
        int nbuf;
        int i;
        int tmpbuflen;
-       char tmpbuf[TMPBUFLEN];
-       char *p = tmpbuf;
+       char *tmpbuf;
+       char *p;
        int too_much_data;
 
+       tmpbuf = kzalloc(TMPBUFLEN, GFP_KERNEL);
+       if (!tmpbuf)
+               return;
+       p = tmpbuf;
+
        /* Leave if sniff not open */
        if (!(ch->ch_sniff_flags & SNIFF_OPEN))
-               return;
+               goto exit;
 
        do_gettimeofday(&tv);
 
@@ -534,7 +539,7 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int
                         * function was probably called by the interrupt/timer routines!
                         */
                        if (n == 0)
-                               return;
+                               goto exit;
 
                        /*
                         * Copy as much data as will fit.
@@ -579,6 +584,9 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int
                }
 
        } while (too_much_data);
+
+exit:
+       kfree(tmpbuf);
 }