]> git.hungrycats.org Git - linux/commitdiff
UBI: fix missing brace control flow
authorBrian Norris <computersforpeace@gmail.com>
Mon, 23 Feb 2015 21:07:22 +0000 (13:07 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 6 Jun 2016 23:11:13 +0000 (19:11 -0400)
[ Upstream commit b388e6a7a6ba988998ddd83919ae8d3debf1a13d ]

commit 0e707ae79ba3 ("UBI: do propagate positive error codes up") seems
to have produced an unintended change in the control flow here.

Completely untested, but it looks obvious.

Caught by Coverity, which didn't like the indentation. CID 1271184.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/mtd/ubi/eba.c

index 34c9e31e891ea1c088851092b0fa4a6d94881cbe..fce8151a3caebda02d607fe7199943e9b1309ab3 100644 (file)
@@ -425,9 +425,10 @@ retry:
                                        ubi_warn("corrupted VID header at PEB %d, LEB %d:%d",
                                                 pnum, vol_id, lnum);
                                        err = -EBADMSG;
-                               } else
+                               } else {
                                        err = -EINVAL;
                                        ubi_ro_mode(ubi);
+                               }
                        }
                        goto out_free;
                } else if (err == UBI_IO_BITFLIPS)