]> git.hungrycats.org Git - linux/commitdiff
ppp: Destroy the mutex when cleanup
authorGao Feng <gfree.wind@vip.163.com>
Tue, 31 Oct 2017 10:25:37 +0000 (18:25 +0800)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 17 Jan 2018 17:55:38 +0000 (12:55 -0500)
[ Upstream commit f02b2320b27c16b644691267ee3b5c110846f49e ]

The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the
good readbility, it's better to invoke it in exit func when the init
func invokes mutex_init.

Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/net/ppp/ppp_generic.c

index 51ba895f052276057a92027efb5a47ed5f1733df..c30c1fc7889aa98cd3dd036ceb7d4926e9251695 100644 (file)
@@ -918,6 +918,7 @@ static __net_exit void ppp_exit_net(struct net *net)
 {
        struct ppp_net *pn = net_generic(net, ppp_net_id);
 
+       mutex_destroy(&pn->all_ppp_mutex);
        idr_destroy(&pn->units_idr);
 }