]> git.hungrycats.org Git - linux/commitdiff
wifi: mt76: mt7921: Check devm_kasprintf() returned value
authorMa Ke <make24@iscas.ac.cn>
Tue, 3 Sep 2024 01:44:55 +0000 (09:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:33:36 +0000 (16:33 +0200)
commit 1ccc9e476ce76e8577ba4fdbd1f63cb3e3499d38 upstream.

devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviwed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://patch.msgid.link/20240903014455.4144536-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/mediatek/mt76/mt7921/init.c

index 57672c69150e489ab19338e3da3050d6d9d0d01d..d1d64fa7d35d02ca74c7ed207312009e41f80734 100644 (file)
@@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy)
 
        name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s",
                              wiphy_name(wiphy));
+       if (!name)
+               return -ENOMEM;
 
        hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
                                                       mt7921_hwmon_groups);