]> git.hungrycats.org Git - linux/commitdiff
net: ax25: fix information leak to userland harder
authorKees Cook <kees.cook@canonical.com>
Wed, 12 Jan 2011 08:34:49 +0000 (00:34 -0800)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:40 +0000 (16:53 +0200)
commit 5b919f833d9d60588d026ad82d17f17e8872c7a9 upstream.

Commit fe10ae53384e48c51996941b7720ee16995cbcb7 adds a memset() to clear
the structure being sent back to userspace, but accidentally used the
wrong size.

Reported-by: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Kees Cook <kees.cook@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ax25/af_ax25.c

index 4a17040aa127c6c4fdd26e6143e7cae4de2f0b4a..e85b959ecad6c8afade7494f875146bd717af40b 100644 (file)
@@ -1384,7 +1384,7 @@ static int ax25_getname(struct socket *sock, struct sockaddr *uaddr,
        ax25_cb *ax25;
        int err = 0;
 
-       memset(fsa, 0, sizeof(fsa));
+       memset(fsa, 0, sizeof(*fsa));
        lock_sock(sk);
        ax25 = ax25_sk(sk);