]> git.hungrycats.org Git - linux/commitdiff
RDMA/ucma: Correct option size check using optlen
authorChien Tin Tung <chien.tin.tung@intel.com>
Wed, 21 Mar 2018 18:09:25 +0000 (13:09 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 16 Jun 2018 21:22:45 +0000 (22:22 +0100)
commit 5f3e3b85cc0a5eae1c46d72e47d3de7bf208d9e2 upstream.

The option size check is using optval instead of optlen
causing the set option call to fail. Use the correct
field, optlen, for size check.

Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size")
Signed-off-by: Chien Tin Tung <chien.tin.tung@intel.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/infiniband/core/ucma.c

index fff990f5423cac084cfeec9905b01b78741b7649..69520ab01a0e2dc5175c21b318bbc710467188e8 100644 (file)
@@ -1200,7 +1200,7 @@ static ssize_t ucma_set_option(struct ucma_file *file, const char __user *inbuf,
        if (IS_ERR(ctx))
                return PTR_ERR(ctx);
 
-       if (unlikely(cmd.optval > KMALLOC_MAX_SIZE))
+       if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE))
                return -EINVAL;
 
        optval = memdup_user((void __user *) (unsigned long) cmd.optval,