]> git.hungrycats.org Git - linux/commitdiff
HID: hid-input: Add parentheses to quell gcc warning
authorJames C Boyd <jcboyd.dev@gmail.com>
Wed, 27 May 2015 22:09:06 +0000 (17:09 -0500)
committerWilly Tarreau <w@1wt.eu>
Sat, 27 Aug 2016 09:40:40 +0000 (11:40 +0200)
commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream.

GCC reports a -Wlogical-not-parentheses warning here; therefore
add parentheses to shut it up and to express our intent more.

Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/hid/hid-input.c

index a3915d12e74641dae3a77be2dab847eca4d907d1..eb5700e40e1a4b589298f91024828275efaeae94 100644 (file)
@@ -1084,7 +1084,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
                return;
 
        /* report the usage code as scancode if the key status has changed */
-       if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
+       if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
                input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
        input_event(input, usage->type, usage->code, value);