usb: typec: ucsi: Ack unsupported commands

commit 6b5c85ddeea77d18c4b69e3bda60e9374a20c304 upstream.

If a command completes the OPM must send an ack. This applies
to unsupported commands, too.

Send the required ACK for unsupported commands.

Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Cc: stable <stable@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Link: https://lore.kernel.org/r/20240320073927.1641788-4-lk@c--e.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index 53a8cfe41fc597cfa2035c81295d6b07a749da8e..cba01a4993a11526d48abb08ab678b7f03b1ce7d 100644 (file)
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -138,8 +138,12 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
        if (!(cci & UCSI_CCI_COMMAND_COMPLETE))
                return -EIO;
 
-       if (cci & UCSI_CCI_NOT_SUPPORTED)
+       if (cci & UCSI_CCI_NOT_SUPPORTED) {
+               if (ucsi_acknowledge_command(ucsi) < 0)
+                       dev_err(ucsi->dev,
+                               "ACK of unsupported command failed\n");
                return -EOPNOTSUPP;
+       }
 
        if (cci & UCSI_CCI_ERROR) {
                if (cmd == UCSI_GET_ERROR_STATUS)