]> git.hungrycats.org Git - linux/commitdiff
ASoC: rockchip: i2s-tdm: Inline PTR_ERR() in dev_err_probe()
authorbui duc phuc <phucduc.bui@gmail.com>
Thu, 6 Aug 2026 05:21:28 +0000 (12:21 +0700)
committerMark Brown <broonie@kernel.org>
Thu, 13 Aug 2026 14:46:01 +0000 (15:46 +0100)
Pass PTR_ERR() directly to dev_err_probe() and avoid assigning it to
the local variable first.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260806052136.21034-7-phucduc.bui@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s_tdm.c

index e6229a325ffe0131d0832c119dbdb93f310bd136..c9ad769a4072588b63a693f5339667ec01c2586d 100644 (file)
@@ -1263,16 +1263,14 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev)
        i2s_tdm->tx_reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
                                                                      "tx-m");
        if (IS_ERR(i2s_tdm->tx_reset)) {
-               ret = PTR_ERR(i2s_tdm->tx_reset);
-               return dev_err_probe(i2s_tdm->dev, ret,
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->tx_reset),
                                     "Error in tx-m reset control\n");
        }
 
        i2s_tdm->rx_reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
                                                                      "rx-m");
        if (IS_ERR(i2s_tdm->rx_reset)) {
-               ret = PTR_ERR(i2s_tdm->rx_reset);
-               return dev_err_probe(i2s_tdm->dev, ret,
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->rx_reset),
                                     "Error in rx-m reset control\n");
        }