[PATCH] AS barrier bug

There's a bug in AS, it sets HARDBARRIER on a request when it should be
setting it as a softbarrier. IO scheduler has no business using that
bit, if it needs to put barriers there they should be soft. Hard
barriers involve hardware operations.

diff --git a/drivers/block/as-iosched.c b/drivers/block/as-iosched.c
index 9d680fcc7c33b3a2dce7045a02ac48d996864175..957e42d1af7b89c00e74c9f1993e9ff920cedfbd 100644 (file)
--- a/drivers/block/as-iosched.c
+++ b/drivers/block/as-iosched.c
@@ -1249,7 +1249,7 @@ fifo_expired:
                        ad->changed_batch = 0;
                } else
                        ad->changed_batch = 2;
-               arq->request->flags |= REQ_HARDBARRIER;
+               arq->request->flags |= REQ_SOFTBARRIER;
        }
 
        /*