Arnd's new-and-improved _IOx() argument checking showed two sound

drivers whose microcode load ioctl's used types with sizes that
overflow the ioctl number. Mark them _IOx_BAD() to document the fact.

diff --git a/include/sound/hdsp.h b/include/sound/hdsp.h
index 5f64cc2cf4e4536e5f37378e9166ca90b3738f24..84d73d20cc83102a56817f99f223294e1a96f8e8 100644 (file)
--- a/include/sound/hdsp.h
+++ b/include/sound/hdsp.h
@@ -71,7 +71,8 @@ struct _snd_hdsp_firmware {
        unsigned long firmware_data[24413];
 };
 
-#define SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE _IOW('H', 0x42, hdsp_firmware_t)
+/* This ioctl is marked bad because the type is bigger than the IOCTL description */
+#define SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE _IOW_BAD('H', 0x42, hdsp_firmware_t)
 
 typedef struct _snd_hdsp_version hdsp_version_t;
 

diff --git a/include/sound/sscape_ioctl.h b/include/sound/sscape_ioctl.h
index baaa75e258f90ce9a1cdfacb93a7d4658d7c5300..aadc930a6ba4767b5b48d82b26b50bd02c59174f 100644 (file)
--- a/include/sound/sscape_ioctl.h
+++ b/include/sound/sscape_ioctl.h
@@ -14,6 +14,8 @@ struct sscape_microcode
 };
 
 #define SND_SSCAPE_LOAD_BOOTB  _IOWR('P', 100, struct sscape_bootblock)
-#define SND_SSCAPE_LOAD_MCODE  _IOW('P', 101, struct sscape_microcode)
+
+/* This ioctl is marked bad because the type is bigger than the IOCTL description */
+#define SND_SSCAPE_LOAD_MCODE  _IOW_BAD('P', 101, struct sscape_microcode)
 
 #endif