]> git.hungrycats.org Git - linux/commitdiff
HID: amd_sfh: Remove unsupported motion-state field from accelerometer report
authorBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Tue, 6 Oct 2026 10:37:53 +0000 (16:07 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:49 +0000 (12:10 -0500)
commit 6ff86122906357687735dd379c6279e3b2fa26af upstream.

The accelerometer HID report descriptor declares a trailing motion-state
field (usage 0x0451), but the Sensor Fusion Hub never reports this data,
so each accelerometer input report is one byte shorter than the descriptor
advertises.

This was previously harmless because hid-core zero-padded short reports.
Since commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing
bogus memset()") such reports are rejected instead:

  hid-sensor-hub 0020:1022:0001.0003: Event data for report 1 was too short (15 vs 14)

As a result the accelerometer input events are dropped and screen
auto-rotation stops working on AMD SFH systems.

Remove the motion-state field from the accelerometer report descriptor and
drop the unused in_accel_shake_detection member, so the descriptor matches
the report actually provided by the hardware.

Fixes: 1434f9fc0e47 ("SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH)")
Reported-by: Andrej Scek <scek.andrej@gmail.com>
Closes: https://lore.kernel.org/linux-input/CADrS85612m-Hh-G4BJmOhy-y6r3Ni3kD8_GM-2QRBeWWEEZWuA@mail.gmail.com/
Cc: stable@vger.kernel.org
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h
drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_report_desc.h

index 882434b1501ff1c2a3e3bc364579b6562195b2c6..230fb69cacfdaab98a668cb88fb11522179762ac 100644 (file)
@@ -48,8 +48,6 @@ struct accel3_input_report {
        int in_accel_x_value;
        int in_accel_y_value;
        int in_accel_z_value;
-       /* include if required to support the "shake" event */
-       u8 in_accel_shake_detection;
 } __packed;
 
 struct gyro_feature_report {
index 67ec2d6a417de5633a58f8e24c1e7487e60223ec..64cff842e5f2618a91c828cd75c4555ade1521dc 100644 (file)
@@ -169,13 +169,6 @@ static const u8 accel3_report_descriptor[] = {
 0x95, 1,               /* HID report count (1) */
 0x55, 0x0E,            /* HID unit exponent(0x0E) */
 0X81, 0x02,            /* HID Input (Data_Arr_Abs) */
-
-0x0A, 0x51, 0x04,      /* HID usage sensor data motion state */
-0x15, 0,               /* HID logical Min_8(0) False = Still*/
-0x25, 1,               /* HID logical Min_8(1) True = In motion */
-0x75, 8,               /* HID report size(8) */
-0x95, 1,               /* HID report count (1) */
-0X81, 0x02,            /* HID Input (Data_Arr_Abs) */
 0xC0                   /* HID end collection */
 };