]> git.hungrycats.org Git - linux/commitdiff
sunrpc: clear XPRT_SOCK_UPD_TIMEOUT when reset transport
authorLiu Jian <liujian56@huawei.com>
Fri, 15 Nov 2024 09:38:04 +0000 (17:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:33:00 +0000 (10:33 +0100)
[ Upstream commit 4db9ad82a6c823094da27de4825af693a3475d51 ]

Since transport->sock has been set to NULL during reset transport,
XPRT_SOCK_UPD_TIMEOUT also needs to be cleared. Otherwise, the
xs_tcp_set_socket_timeouts() may be triggered in xs_tcp_send_request()
to dereference the transport->sock that has been set to NULL.

Fixes: 7196dbb02ea0 ("SUNRPC: Allow changing of the TCP timeout parameters on the fly")
Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
Signed-off-by: Liu Jian <liujian56@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sunrpc/xprtsock.c

index 50490b1e8a0d094f40508c72a8a29783fd96863f..714da627fba8ec633d1b1c0fce25cedb6255dbdc 100644 (file)
@@ -1186,6 +1186,7 @@ static void xs_sock_reset_state_flags(struct rpc_xprt *xprt)
        clear_bit(XPRT_SOCK_WAKE_WRITE, &transport->sock_state);
        clear_bit(XPRT_SOCK_WAKE_DISCONNECT, &transport->sock_state);
        clear_bit(XPRT_SOCK_NOSPACE, &transport->sock_state);
+       clear_bit(XPRT_SOCK_UPD_TIMEOUT, &transport->sock_state);
 }
 
 static void xs_run_error_worker(struct sock_xprt *transport, unsigned int nr)