[PATCH] drivers/ide/probe.c leaks memory

  drivers/ide/probe.c initializes gd->de_arr and gd->flags twice. Except that
it is unnecessary it also leaks memory.

diff --git a/drivers/ide/probe.c b/drivers/ide/probe.c
index b1b026f76cfcb9663d4c108bf9e9ded60a0bf299..ab7df11e44a7eb318849bf438a25567cb474df15 100644 (file)
--- a/drivers/ide/probe.c
+++ b/drivers/ide/probe.c
@@ -1173,18 +1173,6 @@ static void channel_init(struct ata_channel *ch)
        gd->next        = NULL;                 /* linked list of major devs */
        gd->fops        = ide_fops;             /* file operations */
 
-       gd->de_arr      = kmalloc(sizeof(*gd->de_arr) * MAX_DRIVES, GFP_KERNEL);
-       if (gd->de_arr)
-               memset(gd->de_arr, 0, sizeof(*gd->de_arr) * MAX_DRIVES);
-       else
-           goto err_kmalloc_gd_de_arr;
-
-       gd->flags       = kmalloc(sizeof(*gd->flags) * MAX_DRIVES, GFP_KERNEL);
-       if (gd->flags)
-               memset(gd->flags, 0, sizeof(*gd->flags) * MAX_DRIVES);
-       else
-           goto err_kmalloc_gd_flags;
-
        ch->gd = gd;
        add_gendisk(gd);