[PATCH] jantior: coda: userspace error handling

From: Domen Puncer <domen@coderock.org>

Drop verify_area, using copy*user already (instead).
Also user -EFAULT for error instead of -EINVAL.

diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index 01bd6d78f6f0c55ac8fdad8ed1d62eaaea07f75b..79c8803fe64ca964511417f4f9159294ede0cd9d 100644 (file)
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -588,14 +588,10 @@ int venus_pioctl(struct super_block *sb, struct CodaFid *fid,
         if (outp->coda_ioctl.len > data->vi.out_size) {
                error = -EINVAL;
         } else {
-               error = verify_area(VERIFY_WRITE, data->vi.out, 
-                                    data->vi.out_size);
-               if ( error ) goto exit;
-
                if (copy_to_user(data->vi.out, 
                                 (char *)outp + (long)outp->coda_ioctl.data, 
                                 data->vi.out_size)) {
-                       error = -EINVAL;
+                       error = -EFAULT;
                        goto exit;
                }
         }