gtp: serialize PDP context updates

commit 498386b6d402737db1e2eeed4c385acbf0ef9e34 upstream.

PDP contexts can be deleted through GTP_CMD_DELPDP or while the GTP
network device is being unregistered. The latter is serialized by RTNL,
but the generic-netlink delete path only holds RCU.

Running both paths concurrently can therefore make both paths delete the
same PDP context. The issue was found through static analysis and
reproduced on a KASAN-enabled kernel by a simple two-thread program
racing GTP_CMD_DELPDP against RTM_DELLINK:

  Oops: general protection fault, probably for non-canonical address
  KASAN: maybe wild-memory-access in range
         [0xdead000000000120-0xdead000000000127]
  RIP: gtp_genl_del_pdp+0x1c1/0x420 [gtp]
  RBP: dead000000000122

The second deletion dereferenced the poisoned hlist pprev pointer.

Serialize gtp_pdp_add(), gtp_genl_del_pdp(), and gtp_dellink() with a
shared mutex. Keep the mutex held until the final use of a PDP context in
the NEWPDP path, and keep the RCU read-side section around the complete
PDP context use in the DELPDP path.

Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
Cc: stable@vger.kernel.org
Signed-off-by: Qing Ming <a0yami@mailbox.org>
Link: https://patch.msgid.link/20260818150000.7670-1-a0yami@mailbox.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index 98614d0b390b8c80d69bc1ddcad4631cfdcab5ff..af45118083ca2cf178e062dd5142e130689e20ef 100644 (file)
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -12,6 +12,7 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/skbuff.h>
 #include <linux/udp.h>
 #include <linux/rculist.h>
@@ -108,6 +109,7 @@ struct gtp_net {
 };
 
 static u32 gtp_h_initval;
+static DEFINE_MUTEX(gtp_pdp_lock);
 
 static struct genl_family gtp_genl_family;
 
@@ -151,7 +153,8 @@ static struct pdp_ctx *gtp0_pdp_find(struct gtp_dev *gtp, u64 tid, u16 family)
 
        head = &gtp->tid_hash[gtp0_hashfn(tid) % gtp->hash_size];
 
-       hlist_for_each_entry_rcu(pdp, head, hlist_tid) {
+       hlist_for_each_entry_rcu(pdp, head, hlist_tid,
+                                lockdep_is_held(&gtp_pdp_lock)) {
                if (pdp->af == family &&
                    pdp->gtp_version == GTP_V0 &&
                    pdp->u.v0.tid == tid)
@@ -168,7 +171,8 @@ static struct pdp_ctx *gtp1_pdp_find(struct gtp_dev *gtp, u32 tid, u16 family)
 
        head = &gtp->tid_hash[gtp1u_hashfn(tid) % gtp->hash_size];
 
-       hlist_for_each_entry_rcu(pdp, head, hlist_tid) {
+       hlist_for_each_entry_rcu(pdp, head, hlist_tid,
+                                lockdep_is_held(&gtp_pdp_lock)) {
                if (pdp->af == family &&
                    pdp->gtp_version == GTP_V1 &&
                    pdp->u.v1.i_tei == tid)
@@ -185,7 +189,8 @@ static struct pdp_ctx *ipv4_pdp_find(struct gtp_dev *gtp, __be32 ms_addr)
 
        head = &gtp->addr_hash[ipv4_hashfn(ms_addr) % gtp->hash_size];
 
-       hlist_for_each_entry_rcu(pdp, head, hlist_addr) {
+       hlist_for_each_entry_rcu(pdp, head, hlist_addr,
+                                lockdep_is_held(&gtp_pdp_lock)) {
                if (pdp->af == AF_INET &&
                    pdp->ms.addr.s_addr == ms_addr)
                        return pdp;
@@ -220,7 +225,8 @@ static struct pdp_ctx *ipv6_pdp_find(struct gtp_dev *gtp,
 
        head = &gtp->addr_hash[ipv6_hashfn(ms_addr) % gtp->hash_size];
 
-       hlist_for_each_entry_rcu(pdp, head, hlist_addr) {
+       hlist_for_each_entry_rcu(pdp, head, hlist_addr,
+                                lockdep_is_held(&gtp_pdp_lock)) {
                if (pdp->af == AF_INET6 &&
                    ipv6_pdp_addr_equal(&pdp->ms.addr6, ms_addr))
                        return pdp;
@@ -1555,9 +1561,11 @@ static void gtp_dellink(struct net_device *dev, struct list_head *head)
        struct pdp_ctx *pctx;
        int i;
 
+       mutex_lock(&gtp_pdp_lock);
        for (i = 0; i < gtp->hash_size; i++)
                hlist_for_each_entry_safe(pctx, next, &gtp->tid_hash[i], hlist_tid)
                        pdp_context_delete(pctx);
+       mutex_unlock(&gtp_pdp_lock);
 
        list_del(&gtp->list);
        unregister_netdevice_queue(dev, head);
@@ -2053,6 +2061,7 @@ static int gtp_genl_new_pdp(struct sk_buff *skb, struct genl_info *info)
                goto out_unlock;
        }
 
+       mutex_lock(&gtp_pdp_lock);
        pctx = gtp_pdp_add(gtp, sk, info);
        if (IS_ERR(pctx)) {
                err = PTR_ERR(pctx);
@@ -2060,6 +2069,7 @@ static int gtp_genl_new_pdp(struct sk_buff *skb, struct genl_info *info)
                gtp_tunnel_notify(pctx, GTP_CMD_NEWPDP, GFP_KERNEL);
                err = 0;
        }
+       mutex_unlock(&gtp_pdp_lock);
 
 out_unlock:
        rtnl_unlock();
@@ -2134,6 +2144,8 @@ static int gtp_genl_del_pdp(struct sk_buff *skb, struct genl_info *info)
        if (!info->attrs[GTPA_VERSION])
                return -EINVAL;
 
+       mutex_lock(&gtp_pdp_lock);
+
        rcu_read_lock();
 
        pctx = gtp_find_pdp(sock_net(skb->sk), info->attrs);
@@ -2154,6 +2166,7 @@ static int gtp_genl_del_pdp(struct sk_buff *skb, struct genl_info *info)
 
 out_unlock:
        rcu_read_unlock();
+       mutex_unlock(&gtp_pdp_lock);
        return err;
 }