]> git.hungrycats.org Git - linux/commitdiff
ALSA: control: Fix leftover snd_power_unref()
authorTakashi Iwai <tiwai@suse.de>
Thu, 1 Aug 2024 06:42:01 +0000 (08:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2024 10:01:13 +0000 (12:01 +0200)
commit fef1ac950c600ba50ef4d65ca03c8dae9be7f9ea upstream.

One snd_power_unref() was forgotten and left at __snd_ctl_elem_info()
in the previous change for reorganizing the locking order.

Fixes: fcc62b19104a ("ALSA: control: Take power_ref lock primarily")
Link: https://github.com/thesofproject/linux/pull/5127
Link: https://patch.msgid.link/20240801064203.30284-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/control.c

index 2151f19b432fd97a817296b13d7ef5593fe4fd52..c18a9e6539b37af3b410a13804a768208525c2e4 100644 (file)
@@ -1165,7 +1165,6 @@ static int __snd_ctl_elem_info(struct snd_card *card,
        info->access = 0;
 #endif
        result = kctl->info(kctl, info);
-       snd_power_unref(card);
        if (result >= 0) {
                snd_BUG_ON(info->access);
                index_offset = snd_ctl_get_ioff(kctl, &info->id);