[PATCH] double down() in nfsd_symlink

As a result of the recent BKL removal in notify_change, nfsd_symlink
downs the inode semaphore twice (the first time is in fh_lock).

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index aecd48f0d130ffaa183ef6f34bb5c8e2dec6025d..ffe421d0d1497a3736b92f758df554785986f3f6 100644 (file)
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1127,9 +1127,7 @@ nfsd_symlink(struct svc_rqst *rqstp, struct svc_fh *fhp,
                                iap->ia_valid |= ATTR_CTIME;
                                iap->ia_mode = (iap->ia_mode&S_IALLUGO)
                                        | S_IFLNK;
-                               down(&dentry->d_inode->i_sem);
                                err = notify_change(dnew, iap);
-                               up(&dentry->d_inode->i_sem);
                                if (!err && EX_ISSYNC(fhp->fh_export))
                                        write_inode_now(dentry->d_inode, 1);
                       }