]> git.hungrycats.org Git - linux/commitdiff
x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Thu, 15 Feb 2007 02:34:23 +0000 (03:34 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 23 Feb 2007 23:49:52 +0000 (15:49 -0800)
Also PTRACE_OLDSETOPTIONS should be accepted, as done by kernel/ptrace.c and
forced by binary compatibility. UML/32bit breaks because of this - since it is wise
enough to use PTRACE_OLDSETOPTIONS to be binary compatible with 2.4 host
kernels.

Until 2.6.17 (commit f0f2d6536e3515b5b1b7ae97dc8f176860c8c2ce) we had:

       default:
                return sys_ptrace(request, pid, addr, data);

Instead here we have:
        case PTRACE_GET_THREAD_AREA:
case ...:
                return sys_ptrace(request, pid, addr, data);

        default:
                return -EINVAL;

This change was a style change - when a case is added, it must be explicitly
tested this way. In this case, not enough testing was done.

Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86_64/ia32/ptrace32.c

index 659c0722f6b825c75ca7d86743a872630cd9c45f..215dfac4b6ae6c784a9c6b27a3ee0b6f3222171b 100644 (file)
@@ -239,6 +239,7 @@ asmlinkage long sys32_ptrace(long request, u32 pid, u32 addr, u32 data)
        case PTRACE_SINGLESTEP:
        case PTRACE_DETACH:
        case PTRACE_SYSCALL:
+       case PTRACE_OLDSETOPTIONS:
        case PTRACE_SETOPTIONS:
                return sys_ptrace(request, pid, addr, data);