]> git.hungrycats.org Git - linux/commitdiff
wifi: iwlwifi: mvm: d3: fix WoWLAN command version lookup
authorYedidya Benshimol <yedidya.ben.shimol@intel.com>
Fri, 10 May 2024 14:06:29 +0000 (17:06 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2024 07:53:21 +0000 (09:53 +0200)
[ Upstream commit b7ffca99313d856f7d1cc89038d9061b128e8e97 ]

After moving from commands to notificaitons in the d3 resume flow,
removing the WOWLAN_GET_STATUSES and REPLY_OFFLOADS_QUERY_CMD causes
the return of the default value when looking up their version.
Returning zero here results in the driver sending the not supported
NON_QOS_TX_COUNTER_CMD.

Signed-off-by: Yedidya Benshimol <yedidya.ben.shimol@intel.com>
Reviewed-by: Gregory Greenman <gregory.greenman@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240510170500.8cabfd580614.If3a0db9851f56041f8f5360959354abd5379224a@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index 52518a47554e7087ded4782c24fd62340a17384a..74743c3ceeefb1531991ea2c36f74d129831283a 100644 (file)
@@ -2182,7 +2182,8 @@ static bool iwl_mvm_setup_connection_keep(struct iwl_mvm *mvm,
 
 out:
        if (iwl_fw_lookup_notif_ver(mvm->fw, LONG_GROUP,
-                                   WOWLAN_GET_STATUSES, 0) < 10) {
+                                   WOWLAN_GET_STATUSES,
+                                   IWL_FW_CMD_VER_UNKNOWN) < 10) {
                mvmvif->seqno_valid = true;
                /* +0x10 because the set API expects next-to-use, not last-used */
                mvmvif->seqno = status->non_qos_seq_ctr + 0x10;