]> git.hungrycats.org Git - linux/commitdiff
media: platform: rga: fix 32-bit DMA limitation
authorJohn Keeping <jkeeping@inmusicbrands.com>
Mon, 12 Aug 2024 14:35:55 +0000 (15:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:40:58 +0000 (10:40 +0100)
commit 953c03d8cb41d08fe6994f5d94c4393ac9da2f13 upstream.

The destination buffer flags are assigned twice but source is not set in
what looks like a copy+paste mistake.  Assign the source queue flags so
the 32-bit DMA limitation is handled consistently.

Fixes: ec9ef8dda2a2 ("media: rockchip: rga: set dma mask to 32 bits")
Cc: <stable@vger.kernel.org>
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/rockchip/rga/rga.c

index 0e768f3e9edab404c97931b572d1471929415bf1..de532b7ecd74c13e67866c70f55904f333de96ea 100644 (file)
@@ -102,7 +102,7 @@ queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
        src_vq->drv_priv = ctx;
        src_vq->ops = &rga_qops;
        src_vq->mem_ops = &vb2_dma_sg_memops;
-       dst_vq->gfp_flags = __GFP_DMA32;
+       src_vq->gfp_flags = __GFP_DMA32;
        src_vq->buf_struct_size = sizeof(struct rga_vb_buffer);
        src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
        src_vq->lock = &ctx->rga->mutex;