]> git.hungrycats.org Git - linux/commitdiff
HID: hid-lenovo-go-s: Bound stale reply window before reusing send_cmd_complete
authorDerek J. Clark <derekjohn.clark@gmail.com>
Mon, 14 Sep 2026 22:52:55 +0000 (15:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:51 +0000 (12:10 -0500)
commit 6224755416e627badf69b330afec9ac6b85e5098 upstream.

mcu_property_out() reinits send_cmd_complete immediately after a
timeout is detected, before the next command that reuses it is sent.
If the MCU's reply to the timed-out command arrives after this reinit
but before the next command's wait begins, it silently satisfies the
next, unrelated command's wait instead of the one it actually answers,
handing that caller stale data with no way to detect the mismatch.

Track when a command has timed out via cmd_orphaned. Before the next
command reuses the completion, wait a bounded 25ms for a stale reply
to arrive and be consumed, then unconditionally clear the flag and
reinit the completion. This does not fully eliminate the window in
which an unrelated reply could still be received, but bounds it to
a short interval right before a new command is sent. Behavior matches
the solution to the same problem in hid-msi.

Fixes: a23f3497bf208c59ad ("HID: hid-lenovo-go-s: Add Lenovo Legion Go S Series HID Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-lenovo-go-s.c

index f379281d130f09154604c3185e4a8db88b5677a6..aa2e8856a86baee2f266fc0b61e7a1bbdffb044e 100644 (file)
@@ -37,6 +37,7 @@ static struct hid_gos_cfg {
        struct completion send_cmd_complete;
        struct led_classdev *led_cdev;
        struct hid_device *hdev;
+       bool orphan_ack_pending;
        struct mutex cfg_mutex; /*ensure single synchronous output report*/
        bool gp_registered;
        bool rgb_registered;
@@ -456,6 +457,19 @@ static int mcu_property_out(struct hid_device *hdev, u8 command, u8 index,
                return -EINVAL;
 
        guard(mutex)(&drvdata.cfg_mutex);
+
+       /*
+        * A reply to the previous command may still be in flight. Give it a
+        * short window to arrive and be consumed before this call reinits the
+        * completion, so a late reply can't be mistaken for this command's.
+        */
+       if (drvdata.orphan_ack_pending) {
+               wait_for_completion_timeout(&drvdata.send_cmd_complete, msecs_to_jiffies(25));
+               drvdata.orphan_ack_pending = false;
+               drvdata.cmd_status = -ETIMEDOUT;
+       }
+       reinit_completion(&drvdata.send_cmd_complete);
+
        /* We can't use a devm_alloc reusable buffer without side effects during suspend */
        dmabuf = kzalloc(GO_S_PACKET_SIZE, GFP_KERNEL);
        if (!dmabuf)
@@ -481,7 +495,9 @@ static int mcu_property_out(struct hid_device *hdev, u8 command, u8 index,
                                                        msecs_to_jiffies(timeout));
        ret = ret > 0 ? drvdata.cmd_status : ret ?: -EBUSY;
 
-       reinit_completion(&drvdata.send_cmd_complete);
+       if (ret)
+               drvdata.orphan_ack_pending = true;
+
        return ret;
 }