]> git.hungrycats.org Git - linux/commitdiff
usb: misc: legousbtower: Fix memory leak
authorMaksim Salau <maksim.salau@gmail.com>
Sat, 13 May 2017 20:49:26 +0000 (23:49 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 May 2017 12:18:02 +0000 (14:18 +0200)
commit 0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3 upstream.

get_version_reply is not freed if function returns with success.

Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")
Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c

index 34b5d60b477a7e94cd479965e3617b7b93e9c185..b55f590914925ed2c018cd1f19a5befd3a620c51 100644 (file)
@@ -954,6 +954,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
 
 
 exit:
+       kfree(get_version_reply);
        return retval;
 
 error: