]> git.hungrycats.org Git - linux/commitdiff
lpfc: Fix scsi prep dma buf error.
authorJames Smart <james.smart@avagotech.com>
Fri, 22 May 2015 14:42:39 +0000 (10:42 -0400)
committerJiri Slaby <jslaby@suse.cz>
Wed, 2 Sep 2015 13:49:54 +0000 (15:49 +0200)
commit 5116fbf136ea21b8678a85eee5c03508736ada9f upstream.

Didn't check for less-than-or-equal zero. Means we may later call
scsi_dma_unmap() even though we don't have valid mappings.

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/scsi/lpfc/lpfc_scsi.c

index c913e8cc3b269ca82096efd6e356dc8e9e635de9..ed7759980c47991366a5135a7e4725bf56d13a10 100644 (file)
@@ -3423,7 +3423,7 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_scsi_buf *lpfc_cmd)
                 */
 
                nseg = scsi_dma_map(scsi_cmnd);
-               if (unlikely(!nseg))
+               if (unlikely(nseg <= 0))
                        return 1;
                sgl += 1;
                /* clear the last flag in the fcp_rsp map entry */