]> git.hungrycats.org Git - linux/commitdiff
drm/amdgpu: retire legacy get_retire_flip_bits for UMC
authorCe Sun <cesun102@amd.com>
Fri, 3 Apr 2026 03:08:29 +0000 (11:08 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 8 Jul 2026 18:20:30 +0000 (14:20 -0400)
Remove the legacy get_retire_flip_bits implementation for UMC v12

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Ce Sun <cesun102@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/umc_v12_0.c

index d627123249406ae46c506fb2a7822124cf3c03c3..d3eeaead7ca277844112e68fed0c7ce082ad081a 100644 (file)
@@ -73,115 +73,9 @@ bool umc_v12_0_is_correctable_error(struct amdgpu_device *adev, uint64_t mc_umc_
                !(umc_v12_0_is_uncorrectable_error(adev, mc_umc_status)))));
 }
 
-static void umc_v12_0_get_retire_flip_bits(struct amdgpu_device *adev)
-{
-       enum amdgpu_memory_partition nps = AMDGPU_NPS1_PARTITION_MODE;
-       uint32_t vram_type = adev->gmc.vram_type;
-       struct amdgpu_umc_flip_bits *flip_bits = &(adev->umc.flip_bits);
-
-       if (adev->gmc.gmc_funcs->query_mem_partition_mode)
-               nps = adev->gmc.gmc_funcs->query_mem_partition_mode(adev);
-
-       if (adev->gmc.num_umc == 16) {
-               /* default setting */
-               flip_bits->flip_bits_in_pa[0] = UMC_V12_0_PA_C2_BIT;
-               flip_bits->flip_bits_in_pa[1] = UMC_V12_0_PA_C3_BIT;
-               flip_bits->flip_bits_in_pa[2] = UMC_V12_0_PA_C4_BIT;
-               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R13_BIT;
-               flip_bits->flip_row_bit = 13;
-               flip_bits->bit_num = 4;
-               flip_bits->r13_in_pa = UMC_V12_0_PA_R13_BIT;
-
-               if (nps == AMDGPU_NPS2_PARTITION_MODE) {
-                       flip_bits->flip_bits_in_pa[0] = UMC_V12_0_PA_CH5_BIT;
-                       flip_bits->flip_bits_in_pa[1] = UMC_V12_0_PA_C2_BIT;
-                       flip_bits->flip_bits_in_pa[2] = UMC_V12_0_PA_B1_BIT;
-                       flip_bits->r13_in_pa = UMC_V12_0_PA_R12_BIT;
-               } else if (nps == AMDGPU_NPS4_PARTITION_MODE) {
-                       flip_bits->flip_bits_in_pa[0] = UMC_V12_0_PA_CH4_BIT;
-                       flip_bits->flip_bits_in_pa[1] = UMC_V12_0_PA_CH5_BIT;
-                       flip_bits->flip_bits_in_pa[2] = UMC_V12_0_PA_B0_BIT;
-                       flip_bits->r13_in_pa = UMC_V12_0_PA_R11_BIT;
-               }
-
-               switch (vram_type) {
-               case AMDGPU_VRAM_TYPE_HBM:
-                       /* other nps modes are taken as nps1 */
-                       if (nps == AMDGPU_NPS2_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R12_BIT;
-                       else if (nps == AMDGPU_NPS4_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R11_BIT;
-
-                       break;
-               case AMDGPU_VRAM_TYPE_HBM3E:
-                       flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R12_BIT;
-                       flip_bits->flip_row_bit = 12;
-
-                       if (nps == AMDGPU_NPS2_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R11_BIT;
-                       else if (nps == AMDGPU_NPS4_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R10_BIT;
-
-                       break;
-               default:
-                       dev_warn(adev->dev,
-                               "Unknown HBM type, set RAS retire flip bits to the value in NPS1 mode.\n");
-                       break;
-               }
-       } else if (adev->gmc.num_umc == 8) {
-               /* default setting */
-               flip_bits->flip_bits_in_pa[0] = UMC_V12_0_PA_CH5_BIT;
-               flip_bits->flip_bits_in_pa[1] = UMC_V12_0_PA_C2_BIT;
-               flip_bits->flip_bits_in_pa[2] = UMC_V12_0_PA_B1_BIT;
-               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R11_BIT;
-               flip_bits->flip_row_bit = 12;
-               flip_bits->bit_num = 4;
-               flip_bits->r13_in_pa = UMC_V12_0_PA_R12_BIT;
-
-               if (nps == AMDGPU_NPS2_PARTITION_MODE) {
-                       flip_bits->flip_bits_in_pa[0] = UMC_V12_0_PA_CH4_BIT;
-                       flip_bits->flip_bits_in_pa[1] = UMC_V12_0_PA_CH5_BIT;
-                       flip_bits->flip_bits_in_pa[2] = UMC_V12_0_PA_B0_BIT;
-                       flip_bits->r13_in_pa = UMC_V12_0_PA_R11_BIT;
-               }
-
-               switch (vram_type) {
-               case AMDGPU_VRAM_TYPE_HBM:
-                       flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R12_BIT;
-
-                       /* other nps modes are taken as nps1 */
-                       if (nps == AMDGPU_NPS2_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R11_BIT;
-
-                       break;
-               case AMDGPU_VRAM_TYPE_HBM3E:
-                       flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R11_BIT;
-                       flip_bits->flip_row_bit = 12;
-
-                       if (nps == AMDGPU_NPS2_PARTITION_MODE)
-                               flip_bits->flip_bits_in_pa[3] = UMC_V12_0_PA_R10_BIT;
-
-                       break;
-               default:
-                       dev_warn(adev->dev,
-                               "Unknown HBM type, set RAS retire flip bits to the value in NPS1 mode.\n");
-                       break;
-               }
-       } else {
-               dev_warn(adev->dev,
-                       "Unsupported UMC number(%d), failed to set RAS flip bits.\n",
-                       adev->gmc.num_umc);
-
-               return;
-       }
-
-       adev->umc.retire_unit = 0x1 << flip_bits->bit_num;
-}
-
 struct amdgpu_umc_ras umc_v12_0_ras = {
        .ras_block = {
                .hw_ops = NULL,
        },
-       .get_retire_flip_bits = umc_v12_0_get_retire_flip_bits,
 };