]> git.hungrycats.org Git - linux/commitdiff
HID: roccat: isku: reject short button reports
authorJiale Yao <yaojiale02@163.com>
Thu, 24 Sep 2026 14:29:11 +0000 (22:29 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:06:11 +0000 (12:06 -0500)
commit 93e5f7f6189af76a2b2e2dfe647838a7b9f99d21 upstream.

The raw event callback runs before HID core validates and zero-pads the
report.  It passes the buffer to helpers which inspect data[0] and, for a
button report, read the complete struct isku_report_button.  A truncated
report can therefore cause an out-of-bounds read.

Require enough data for the button report before calling either helper.
Commit 47669bec44fe ("HID: asus: refactor the two workqueues and init
sequence") added the same kind of raw-event length validation to hid-asus.

Fixes: d41c2a7011df ("HID: roccat: Add support for Isku keyboard")
Cc: stable@vger.kernel.org
Signed-off-by: Jiale Yao <yaojiale02@163.com>
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-roccat-isku.c

index 339378771ed506a87ea4328e299774dc93363854..5f28f3bfe2ed2c53e650d83395f8c3b6b74d03eb 100644 (file)
@@ -411,6 +411,9 @@ static int isku_raw_event(struct hid_device *hdev,
        if (isku == NULL)
                return 0;
 
+       if (size < sizeof(struct isku_report_button))
+               return 0;
+
        isku_keep_values_up_to_date(isku, data);
 
        if (isku->roccat_claimed)