]> git.hungrycats.org Git - linux/commitdiff
drm/i915/selftests: Fix GT PM sort comparators
authorEmre Cecanpunar <emreleno@gmail.com>
Tue, 14 Jul 2026 22:04:30 +0000 (01:04 +0300)
committerTvrtko Ursulin <tursulin@ursulin.net>
Wed, 15 Jul 2026 12:06:07 +0000 (13:06 +0100)
Compare the sampled clock values instead of their addresses. Comparing
addresses leaves the samples unsorted, preventing the code from discarding
the minimum and maximum samples.

Fixes: 1a5392479207 ("drm/i915/selftests: Measure CS_TIMESTAMP")
Signed-off-by: Emre Cecanpunar <emreleno@gmail.com>
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
Link: https://lore.kernel.org/r/20260714220430.238433-1-emreleno@gmail.com
drivers/gpu/drm/i915/gt/selftest_gt_pm.c

index 33351deeea4f0b7797b554eb3144319001063840..07eaf71955c4478f83fc635cec21ad4ccc55a4ad 100644 (file)
@@ -16,9 +16,9 @@ static int cmp_u64(const void *A, const void *B)
 {
        const u64 *a = A, *b = B;
 
-       if (a < b)
+       if (*a < *b)
                return -1;
-       else if (a > b)
+       else if (*a > *b)
                return 1;
        else
                return 0;
@@ -28,9 +28,9 @@ static int cmp_u32(const void *A, const void *B)
 {
        const u32 *a = A, *b = B;
 
-       if (a < b)
+       if (*a < *b)
                return -1;
-       else if (a > b)
+       else if (*a > *b)
                return 1;
        else
                return 0;