]> git.hungrycats.org Git - linux/commitdiff
ASoC: Intel: avs: Use auto-cleanup for firmware loading
authorTakashi Iwai <tiwai@suse.de>
Thu, 6 Aug 2026 13:59:58 +0000 (15:59 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 10 Aug 2026 14:34:12 +0000 (15:34 +0100)
Simplify the code to manage the firmware loading with __free(firmware)
auto-cleanup.

Only the code refactoring, no functional changes.

Cc: Cezary Rojewski <cezary.rojewski@intel.com>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260806140006.1412298-27-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/topology.c

index 9033f683393c43ec1fc580b18574eee24347ffaa..673ac31f2fea1ad4dee72483008ca9e7bae1826e 100644 (file)
@@ -2222,7 +2222,7 @@ struct avs_tplg *avs_tplg_new(struct snd_soc_component *comp)
 
 int avs_load_topology(struct snd_soc_component *comp, const char *filename)
 {
-       const struct firmware *fw;
+       const struct firmware *fw __free(firmware) = NULL;
        int ret;
 
        ret = request_firmware(&fw, filename, comp->dev);
@@ -2235,7 +2235,6 @@ int avs_load_topology(struct snd_soc_component *comp, const char *filename)
        if (ret < 0)
                dev_err(comp->dev, "load topology \"%s\" failed: %d\n", filename, ret);
 
-       release_firmware(fw);
        return ret;
 }