[SPARC32]: Mask PIL in local_irq operations.

Also, un-inline large local_irq functions.

diff --git a/arch/sparc/kernel/irq.c b/arch/sparc/kernel/irq.c
index 87378e7711ebaf5dd1c794e6f07cb750886f0d38..3c982da8bb17306d266a5b7ab580c30711296caa 100644 (file)
--- a/arch/sparc/kernel/irq.c
+++ b/arch/sparc/kernel/irq.c
@@ -52,6 +52,66 @@
 /* Used to protect the IRQ action lists */
 spinlock_t irq_action_lock = SPIN_LOCK_UNLOCKED;
 
+#ifdef CONFIG_SMP
+#define SMP_NOP2 "nop; nop;\n\t"
+#define SMP_NOP3 "nop; nop; nop;\n\t"
+#else
+#define SMP_NOP2
+#define SMP_NOP3
+#endif /* SMP */
+unsigned long __local_irq_save(void)
+{
+       unsigned long retval;
+       unsigned long tmp;
+
+       __asm__ __volatile__(
+               "rd     %%psr, %0\n\t"
+               SMP_NOP3        /* Sun4m + Cypress + SMP bug */
+               "or     %0, %2, %1\n\t"
+               "wr     %1, 0, %%psr\n\t"
+               "nop; nop; nop\n"
+               : "=&r" (retval), "=r" (tmp)
+               : "i" (PSR_PIL)
+               : "memory");
+
+       return retval;
+}
+
+void local_irq_enable(void)
+{
+       unsigned long tmp;
+
+       __asm__ __volatile__(
+               "rd     %%psr, %0\n\t"
+               SMP_NOP3        /* Sun4m + Cypress + SMP bug */
+               "andn   %0, %1, %0\n\t"
+               "wr     %0, 0, %%psr\n\t"
+               "nop; nop; nop\n"
+               : "=&r" (tmp)
+               : "i" (PSR_PIL)
+               : "memory");
+}
+
+void local_irq_restore(unsigned long old_psr)
+{
+       unsigned long tmp;
+
+       __asm__ __volatile__(
+               "rd     %%psr, %0\n\t"
+               "and    %2, %1, %2\n\t"
+               SMP_NOP2        /* Sun4m + Cypress + SMP bug */
+               "andn   %0, %1, %0\n\t"
+               "wr     %0, %2, %%psr\n\t"
+               "nop; nop; nop\n"
+               : "=&r" (tmp)
+               : "i" (PSR_PIL), "r" (old_psr)
+               : "memory");
+}
+
+EXPORT_SYMBOL(__local_irq_save);
+EXPORT_SYMBOL(local_irq_enable);
+EXPORT_SYMBOL(local_irq_restore);
+
 /*
  * Dave Redman (djhr@tadpole.co.uk)
  *

diff --git a/arch/sparc/kernel/process.c b/arch/sparc/kernel/process.c
index f7f20790ed9f5c5422a45b65c858ddbe9e4468cf..7e6c60d5077531a24730dd37793f04f33945268d 100644 (file)
--- a/arch/sparc/kernel/process.c
+++ b/arch/sparc/kernel/process.c
@@ -148,11 +148,12 @@ extern char reboot_command [];
 
 extern void (*prom_palette)(int);
 
+/* XXX cli/sti -> local_irq_xxx here, check this works once SMP is fixed. */
 void machine_halt(void)
 {
-       sti();
+       local_irq_enable();
        mdelay(8);
-       cli();
+       local_irq_disable();
        if (!serial_console && prom_palette)
                prom_palette (1);
        prom_halt();
@@ -165,9 +166,9 @@ void machine_restart(char * cmd)
 {
        char *p;
        
-       sti();
+       local_irq_enable();
        mdelay(8);
-       cli();
+       local_irq_disable();
 
        p = strchr (reboot_command, '\n');
        if (p) *p = 0;

diff --git a/arch/sparc/kernel/sparc_ksyms.c b/arch/sparc/kernel/sparc_ksyms.c
index 84c5e3108012ecd25c8a1eeac56296db3590330d..80e007d6febca80f24522296c9a290bfa351a651 100644 (file)
--- a/arch/sparc/kernel/sparc_ksyms.c
+++ b/arch/sparc/kernel/sparc_ksyms.c
@@ -159,10 +159,6 @@ EXPORT_SYMBOL(___change_bit);
 /* IRQ implementation. */
 EXPORT_SYMBOL(global_irq_holder);
 EXPORT_SYMBOL(synchronize_irq);
-EXPORT_SYMBOL(__global_cli);
-EXPORT_SYMBOL(__global_sti);
-EXPORT_SYMBOL(__global_save_flags);
-EXPORT_SYMBOL(__global_restore_flags);
 
 /* Misc SMP information */
 EXPORT_SYMBOL(__cpu_number_map);

diff --git a/include/asm-sparc/system.h b/include/asm-sparc/system.h
index b53cf2c6897e9fdfe0df4a2f51a95143e8936035..a4c7d566e075a2f9373537c1ab5f5487e454cf66 100644 (file)
--- a/include/asm-sparc/system.h
+++ b/include/asm-sparc/system.h
@@ -171,32 +171,11 @@ extern void fpsave(unsigned long *fpregs, unsigned long *fsr,
 /*
  * Changing the IRQ level on the Sparc.
  */
-extern __inline__ void setipl(unsigned long __orig_psr)
-{
-       __asm__ __volatile__(
-               "wr     %0, 0x0, %%psr\n\t"
-               "nop; nop; nop\n"
-               : /* no outputs */
-               : "r" (__orig_psr)
-               : "memory", "cc");
-}
+extern void local_irq_restore(unsigned long);
+extern unsigned long __local_irq_save(void);
+extern void local_irq_enable(void);
 
-extern __inline__ void local_irq_enable(void)
-{
-       unsigned long tmp;
-
-       __asm__ __volatile__(
-               "rd     %%psr, %0\n\t"
-               "nop; nop; nop;\n\t"    /* Sun4m + Cypress + SMP bug */
-               "andn   %0, %1, %0\n\t"
-               "wr     %0, 0x0, %%psr\n\t"
-               "nop; nop; nop\n"
-               : "=r" (tmp)
-               : "i" (PSR_PIL)
-               : "memory");
-}
-
-extern __inline__ unsigned long getipl(void)
+static inline unsigned long getipl(void)
 {
        unsigned long retval;
 
@@ -204,76 +183,11 @@ extern __inline__ unsigned long getipl(void)
        return retval;
 }
 
-#if 0 /* not used */
-extern __inline__ unsigned long swap_pil(unsigned long __new_psr)
-{
-       unsigned long retval;
-
-       __asm__ __volatile__(
-               "rd     %%psr, %0\n\t"
-               "nop; nop; nop;\n\t"    /* Sun4m + Cypress + SMP bug */
-               "and    %0, %2, %%g1\n\t"
-               "and    %1, %2, %%g2\n\t"
-               "xorcc  %%g1, %%g2, %%g0\n\t"
-               "be     1f\n\t"
-               " nop\n\t"
-               "wr     %0, %2, %%psr\n\t"
-               "nop; nop; nop;\n"
-               "1:\n"
-               : "=&r" (retval)
-               : "r" (__new_psr), "i" (PSR_PIL)
-               : "g1", "g2", "memory", "cc");
-
-       return retval;
-}
-#endif
-
-extern __inline__ unsigned long read_psr_and_cli(void)
-{
-       unsigned long retval;
-
-       __asm__ __volatile__(
-               "rd     %%psr, %0\n\t"
-               "nop; nop; nop;\n\t"    /* Sun4m + Cypress + SMP bug */
-               "or     %0, %1, %%g1\n\t"
-               "wr     %%g1, 0x0, %%psr\n\t"
-               "nop; nop; nop\n\t"
-               : "=r" (retval)
-               : "i" (PSR_PIL)
-               : "g1", "memory");
-
-       return retval;
-}
-
 #define local_save_flags(flags)        ((flags) = getipl())
-#define local_irq_save(flags)  ((flags) = read_psr_and_cli())
-#define local_irq_restore(flags)       setipl((flags))
-#define local_irq_disable()    ((void) read_psr_and_cli())
-
+#define local_irq_save(flags)  ((flags) = __local_irq_save())
+#define local_irq_disable()    ((void) __local_irq_save())
 #define irqs_disabled()                ((getipl() & PSR_PIL) != 0)
 
-#ifdef CONFIG_SMP
-
-extern unsigned char global_irq_holder;
-
-#define save_and_cli(flags)   do { save_flags(flags); cli(); } while(0)
-
-extern void __global_cli(void);
-extern void __global_sti(void);
-extern unsigned long __global_save_flags(void);
-extern void __global_restore_flags(unsigned long flags);
-#define cli()                  __global_cli()
-#define sti()                  __global_sti()
-#define save_flags(flags)      ((flags)=__global_save_flags())
-#define restore_flags(flags)   __global_restore_flags(flags)
-
-#else
-
-#define cli() local_irq_disable()
-#define sti() local_irq_enable()
-
-#endif
-
 /* XXX Change this if we ever use a PSO mode kernel. */
 #define mb()   __asm__ __volatile__ ("" : : : "memory")
 #define rmb()  mb()