]> git.hungrycats.org Git - linux/commitdiff
HID: asus: do not send keyboard init reports to touchpads
authorPanz Dev <panz.development@gmail.com>
Tue, 18 Aug 2026 15:14:31 +0000 (17:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:50 +0000 (12:10 -0500)
commit 8099f9da59f1c338bf88e25b7aa2a7fdf840879c upstream.

Commit 0919db9f3583 ("HID: asus: always fully initialize devices") added a
loop during asus_probe() to send keyboard feature report initializations
(asus_kbd_init) to all ASUS HID devices.

On ASUS laptops with I2C/HID touchpads (such as the ASUS E200HA), sending
keyboard feature reports (FEATURE_KBD_REPORT_ID) to touchpad endpoints
sends invalid feature requests to touchpad hardware, corrupting probe
state and causing the touchpad to become unresponsive.

Wrap the asus_report_id_init loop in an `if (!drvdata->tp)` check so
keyboard feature initialization only runs for actual keyboards.

Tested on ASUS E200HA (where touchpad functionality is fully restored)
and ASUS VivoBook Flip 14 TP401MA (confirming zero regressions).

Fixes: 0919db9f3583 ("HID: asus: always fully initialize devices")
Cc: stable@vger.kernel.org
Signed-off-by: Panz Dev <panz.development@gmail.com>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-asus.c

index c38a2b3b33d9e8c30605e427ed84e3dfa523aeab..7dc6417fe2622aa9e4b68dd6742e61f72f0ed9d3 100644 (file)
@@ -1493,12 +1493,14 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
                return ret;
        }
 
-       for (int r = 0; r < ARRAY_SIZE(asus_report_id_init); r++) {
-               if (asus_has_report_id(hdev, asus_report_id_init[r])) {
-                       ret = asus_kbd_init(hdev, asus_report_id_init[r]);
-                       if (ret < 0)
-                               hid_warn(hdev, "Failed to initialize 0x%x: %d.\n",
-                                        asus_report_id_init[r], ret);
+       if (!drvdata->tp) {
+               for (int r = 0; r < ARRAY_SIZE(asus_report_id_init); r++) {
+                       if (asus_has_report_id(hdev, asus_report_id_init[r])) {
+                               ret = asus_kbd_init(hdev, asus_report_id_init[r]);
+                               if (ret < 0)
+                                       hid_warn(hdev, "Failed to initialize 0x%x: %d.\n",
+                                                asus_report_id_init[r], ret);
+                       }
                }
        }