]> git.hungrycats.org Git - linux/commitdiff
btrfs: simplify insert_orphan_item
authorDavid Sterba <dsterba@suse.cz>
Fri, 2 Jan 2015 18:12:57 +0000 (19:12 +0100)
committerZygo Blaxell <zblaxell@waya.furryterror.org>
Sat, 7 Mar 2015 22:01:24 +0000 (17:01 -0500)
We can search and add the orphan item in one go,
btrfs_insert_orphan_item will find out if the item already exists.

Signed-off-by: David Sterba <dsterba@suse.cz>
(cherry picked from commit 9c4f61f01d269815bb7c37be3ede59c5587747c6)

fs/btrfs/tree-log.c

index db4af3d15e145f829abadfc72ef1142c13a75e61..84157a949d8721723c597d89ff62f80db185527e 100644 (file)
@@ -1266,21 +1266,13 @@ out:
 }
 
 static int insert_orphan_item(struct btrfs_trans_handle *trans,
-                             struct btrfs_root *root, u64 offset)
+                             struct btrfs_root *root, u64 ino)
 {
        int ret;
-       struct btrfs_path *path;
-
-       path = btrfs_alloc_path();
-       if (!path)
-               return -ENOMEM;
 
-       ret = btrfs_find_item(root, path, BTRFS_ORPHAN_OBJECTID,
-                       offset, BTRFS_ORPHAN_ITEM_KEY, NULL);
-       if (ret > 0)
-               ret = btrfs_insert_orphan_item(trans, root, offset);
-
-       btrfs_free_path(path);
+       ret = btrfs_insert_orphan_item(trans, root, ino);
+       if (ret == -EEXIST)
+               ret = 0;
 
        return ret;
 }