[PATCH] dmfe: don't free skb with local interrupts disabled

dev_kfree_skb() can end up calling local_bh_enable() which goes BUG if local
interrupts are disabled.  Apparently it can deadlock.

So move the skb freeing outside the lock in the dmfe driver.  It will
decrease the lock hold time as well.

diff --git a/drivers/net/tulip/dmfe.c b/drivers/net/tulip/dmfe.c
index ee017a02ecbedf1f50bc5b85cf7f558149eb791c..b2d33c9ac274619770448b9708bda0dab3cbf208 100644 (file)
--- a/drivers/net/tulip/dmfe.c
+++ b/drivers/net/tulip/dmfe.c
@@ -668,13 +668,13 @@ static int dmfe_start_xmit(struct sk_buff *skb, struct DEVICE *dev)
        if ( db->tx_queue_cnt < TX_FREE_DESC_CNT )
                netif_wake_queue(dev);
 
-       /* free this SKB */
-       dev_kfree_skb(skb);
-
        /* Restore CR7 to enable interrupt */
        spin_unlock_irqrestore(&db->lock, flags);
        outl(db->cr7_data, dev->base_addr + DCR7);
 
+       /* free this SKB */
+       dev_kfree_skb(skb);
+
        return 0;
 }