]> git.hungrycats.org Git - linux/commitdiff
[PATCH] Small fix to pci_alloc_consistent()
authorDave Jones <davej@suse.de>
Wed, 3 Apr 2002 03:58:25 +0000 (19:58 -0800)
committerDave Jones <davej@suse.de>
Wed, 3 Apr 2002 03:58:25 +0000 (19:58 -0800)
Original from Badari Pulavarty <pbadari@us.ibm.com>:

pci_alloc_consistent() is returning zone DMA memory to highmem
enabled drivers when it really should have been returning zone NORMAL.

Found this while testing qlogicfc driver for > 4GB support.

arch/i386/kernel/pci-dma.c

index 18a08ccbac1b4e39a25ef09365be873716897f99..2031b8583ecad51aa2d977b0ad91028d196c1846 100644 (file)
@@ -19,7 +19,7 @@ void *pci_alloc_consistent(struct pci_dev *hwdev, size_t size,
        void *ret;
        int gfp = GFP_ATOMIC;
 
-       if (hwdev == NULL || hwdev->dma_mask != 0xffffffff)
+       if (hwdev == NULL || ((u32)hwdev->dma_mask != 0xffffffff))
                gfp |= GFP_DMA;
        ret = (void *)__get_free_pages(gfp, get_order(size));