]> git.hungrycats.org Git - linux/commitdiff
RDMA/rxe: Delete error messages triggered by incoming Read requests
authorDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Mon, 29 Aug 2022 07:12:18 +0000 (16:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:23 +0000 (09:58 +0200)
[ Upstream commit 2c02249fcbfc066bd33e2a7375c7006d4cb367f6 ]

An incoming Read request causes multiple Read responses. If a user MR to
copy data from is unavailable or responder cannot send a reply, then the
error messages can be printed for each response attempt, resulting in
message overflow.

Link: https://lore.kernel.org/r/20220829071218.1639065-1-matsuda-daisuke@fujitsu.com
Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/sw/rxe/rxe_resp.c

index e38bf958ab4852c94a40ed20c429c77b275476d8..2ef21a1cba814a14d2739674d2fd187a0c8c8a5a 100644 (file)
@@ -787,10 +787,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
        if (!skb)
                return RESPST_ERR_RNR;
 
-       err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
-                         payload, RXE_FROM_MR_OBJ);
-       if (err)
-               pr_err("Failed copying memory\n");
+       rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
+                   payload, RXE_FROM_MR_OBJ);
        if (mr)
                rxe_put(mr);
 
@@ -801,10 +799,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
        }
 
        err = rxe_xmit_packet(qp, &ack_pkt, skb);
-       if (err) {
-               pr_err("Failed sending RDMA reply.\n");
+       if (err)
                return RESPST_ERR_RNR;
-       }
 
        res->read.va += payload;
        res->read.resid -= payload;