]> git.hungrycats.org Git - linux/commitdiff
[TG3]: Fix bugs in ETHTOOL_SSET introduced by ethtool_ops conversion.
authorDavid S. Miller <davem@nuts.ninka.net>
Wed, 5 Nov 2003 06:46:25 +0000 (22:46 -0800)
committerDavid S. Miller <davem@nuts.ninka.net>
Wed, 5 Nov 2003 06:46:25 +0000 (22:46 -0800)
- Missing spin_lock*() calls before tp->link_config twiddling.
- Missing assignment to tp->link_config.autoneg

drivers/net/tg3.c

index 92b59780aca99d18b72c445f6d9ca1ab093641f6..68a6316632fb2dab9a4121077b2f0e3a9ab7d728 100644 (file)
@@ -5935,6 +5935,10 @@ static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                                        tp->link_config.phy_is_low_power)
                return -EAGAIN;
 
+       spin_lock_irq(&tp->lock);
+       spin_lock(&tp->tx_lock);
+
+       tp->link_config.autoneg = cmd->autoneg;
        if (cmd->autoneg == AUTONEG_ENABLE) {
                tp->link_config.advertising = cmd->advertising;
                tp->link_config.speed = SPEED_INVALID;