Fix bogus mode bit testing by smbfs.

The S_IFxxxx macros aren't bits to be tested, they
are values of the S_IFMT field.

diff --git a/fs/smbfs/proc.c b/fs/smbfs/proc.c
index 20a12e8033836876ed562343b4c0ad004d18498b..23396aaaaa0b66323525a3fb0d1af4f49a8525bb 100644 (file)
--- a/fs/smbfs/proc.c
+++ b/fs/smbfs/proc.c
@@ -560,19 +560,19 @@ static int smb_filetype_to_mode(u32 filetype)
 
 static u32 smb_filetype_from_mode(int mode)
 {
-       if (mode & S_IFREG)
+       if (S_ISREG(mode))
                return UNIX_TYPE_FILE;
-       if (mode & S_IFDIR)
+       if (S_ISDIR(mode))
                return UNIX_TYPE_DIR;
-       if (mode & S_IFLNK)
+       if (S_ISLNK(mode))
                return UNIX_TYPE_SYMLINK;
-       if (mode & S_IFCHR)
+       if (S_ISCHR(mode))
                return UNIX_TYPE_CHARDEV;
-       if (mode & S_IFBLK)
+       if (S_ISBLK(mode))
                return UNIX_TYPE_BLKDEV;
-       if (mode & S_IFIFO)
+       if (S_ISFIFO(mode))
                return UNIX_TYPE_FIFO;
-       if (mode & S_IFSOCK)
+       if (S_ISSOCK(mode))
                return UNIX_TYPE_SOCKET;
        return UNIX_TYPE_UNKNOWN;
 }