[PATCH] Fix imm/ppa initializing bug in driver updates

Let's play spot the bug here...

Amazing that it survives in modular case...

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index 8b290ea429cf57b4ec662b26eea7c1b835c7e514..66825f08ef85d48f0e49edf213e6f59ef9af6f54 100644 (file)
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -1153,7 +1153,7 @@ static int __imm_attach(struct parport *pb)
        if (!dev)
                return -ENOMEM;
 
-       memset(dev, 0, sizeof(dev));
+       memset(dev, 0, sizeof(imm_struct));
 
        dev->base = -1;
        dev->mode = IMM_AUTODETECT;

diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c
index 69107395eaf8777bfad787f332375c13fea324eb..dfefed5126d4ab7f959077ca714663fb7161e404 100644 (file)
--- a/drivers/scsi/ppa.c
+++ b/drivers/scsi/ppa.c
@@ -1010,7 +1010,7 @@ static int __ppa_attach(struct parport *pb)
        dev = kmalloc(sizeof(ppa_struct), GFP_KERNEL);
        if (!dev)
                return -ENOMEM;
-       memset(dev, 0, sizeof(dev));
+       memset(dev, 0, sizeof(ppa_struct));
        dev->base = -1;
        dev->mode = PPA_AUTODETECT;
        dev->recon_tmo = PPA_RECON_TMO;