]> git.hungrycats.org Git - linux/commitdiff
DECnet: don't leak uninitialized stack byte
authorDan Rosenberg <drosenberg@vsecurity.com>
Tue, 23 Nov 2010 11:02:13 +0000 (11:02 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:24:19 +0000 (13:24 -0800)
commit 3c6f27bf33052ea6ba9d82369fb460726fb779c0 upstream.

A single uninitialized padding byte is leaked to userspace.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/decnet/af_decnet.c

index 3c23ab33dbc0335dabea5348ff913e70fd880062..1140f81528b9f70390b828c1e744a346d30aaf36 100644 (file)
@@ -1558,6 +1558,8 @@ static int __dn_getsockopt(struct socket *sock, int level,int optname, char __us
                        if (r_len > sizeof(struct linkinfo_dn))
                                r_len = sizeof(struct linkinfo_dn);
 
+                       memset(&link, 0, sizeof(link));
+
                        switch(sock->state) {
                                case SS_CONNECTING:
                                        link.idn_linkstate = LL_CONNECTING;