]> git.hungrycats.org Git - linux/commitdiff
perf trace: Do not process PERF_RECORD_LOST twice
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 30 Mar 2016 19:51:17 +0000 (16:51 -0300)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 31 Jul 2017 17:37:53 +0000 (13:37 -0400)
[ Upstream commit 3ed5ca2efff70e9f589087c2013789572901112d ]

We catch this record to provide a visual indication that events are
getting lost, then call the default method to allow extra logging shared
with the other tools to take place.

This extra logging was done twice because we were continuing to the
"default" clause where machine__process_event() will end up calling
machine__process_lost_event() again, fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-wus2zlhw3qo24ye84ewu4aqw@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
tools/perf/builtin-trace.c

index e122970361f21af6d07c321480aefa2cb90bf31d..09b9b74e4c1b4645c398aaea2966982cdb22144f 100644 (file)
@@ -1404,6 +1404,7 @@ static int trace__process_event(struct trace *trace, struct machine *machine,
                color_fprintf(trace->output, PERF_COLOR_RED,
                              "LOST %" PRIu64 " events!\n", event->lost.lost);
                ret = machine__process_lost_event(machine, event, sample);
+               break;
        default:
                ret = machine__process_event(machine, event, sample);
                break;