]> git.hungrycats.org Git - linux/commitdiff
drm/xe/mmio: Drop tiles_fini action
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Mon, 22 Jun 2026 13:23:40 +0000 (15:23 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 23 Jun 2026 17:15:36 +0000 (19:15 +0200)
The pointer zeroing is not required, as we check xe->mmio.regs to
test if code is not trying to access MMIO after a driver unwind.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patch.msgid.link/20260622132342.19600-5-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_mmio.c

index 8dd818e1184c89142cffb1a90511bb5c0193f7f2..58226cd8b39933d6e2990dd1f5128d7bc189170a 100644 (file)
 
 #include "generated/xe_device_wa_oob.h"
 
-static void tiles_fini(void *arg)
-{
-       struct xe_device *xe = arg;
-       struct xe_tile *tile;
-       int id;
-
-       for_each_remote_tile(tile, xe, id)
-               tile->mmio.regs = NULL;
-}
-
 /*
  * On multi-tile devices, partition the BAR space for MMIO on each tile,
  * possibly accounting for register override on the number of tiles available.
@@ -74,8 +64,7 @@ int xe_mmio_probe_tiles(struct xe_device *xe)
        size_t tile_mmio_size = SZ_16M;
 
        mmio_multi_tile_setup(xe, tile_mmio_size);
-
-       return devm_add_action_or_reset(xe->drm.dev, tiles_fini, xe);
+       return 0;
 }
 
 static void mmio_fini(void *arg)