]> git.hungrycats.org Git - linux/commitdiff
wlcore: sdio: check for valid platform device data before suspend
authorEyal Reizer <eyalreizer@gmail.com>
Mon, 28 May 2018 08:36:42 +0000 (11:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Aug 2018 10:20:26 +0000 (12:20 +0200)
[ Upstream commit 6e91d48371e79862ea2c05867aaebe4afe55a865 ]

the wl pointer can be null In case only wlcore_sdio is probed while
no WiLink module is successfully probed, as in the case of mounting a
wl12xx module while using a device tree file configured with wl18xx
related settings.
In this case the system was crashing in wl1271_suspend() as platform
device data is not set.
Make sure wl the pointer is valid before using it.

Signed-off-by: Eyal Reizer <eyalr@ti.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/ti/wlcore/sdio.c

index d3dd7bfdf3f1f33efbfbd9e0be762f664c892926..63b55b2261e55bb9d4015c785015dd7cc16744b8 100644 (file)
@@ -342,6 +342,11 @@ static int wl1271_suspend(struct device *dev)
        mmc_pm_flag_t sdio_flags;
        int ret = 0;
 
+       if (!wl) {
+               dev_err(dev, "no wilink module was probed\n");
+               goto out;
+       }
+
        dev_dbg(dev, "wl1271 suspend. wow_enabled: %d\n",
                wl->wow_enabled);